feat: Adds datadog plugin resources#5192
Merged
kodiakhq[bot] merged 30 commits intocloudquery:mainfrom Dec 1, 2022
Merged
Conversation
Co-authored-by: Herman Schaaf <hermanschaaf@gmail.com>
Co-authored-by: Herman Schaaf <hermanschaaf@gmail.com>
Co-authored-by: Herman Schaaf <hermanschaaf@gmail.com>
# Conflicts: # .github/styles/Vocab/Base/accept.txt
…_resources # Conflicts: # plugins/source/datadog/README.md # plugins/source/datadog/client/client.go # plugins/source/datadog/client/resolvers.go # plugins/source/datadog/client/services.go # plugins/source/datadog/codegen/main.go # plugins/source/datadog/codegen/services/clients.go # plugins/source/datadog/codegen/services/generate.go # plugins/source/datadog/codegen/services/templates/services.go.tpl # plugins/source/datadog/resources/plugin/tables.go # plugins/source/datadog/resources/services/users/users_mock_test.go
hermanschaaf
suggested changes
Nov 30, 2022
Contributor
hermanschaaf
left a comment
There was a problem hiding this comment.
Looks good, that's a lot of resources! I had a brief look through, and just had the one question about PKs.
1 task
hermanschaaf
approved these changes
Dec 1, 2022
Contributor
|
Looks like the table docs will just need to be regenerated with the new (nested lists) format. |
Member
|
/gen sha=7e7a4ecd6e109e576d7ce037e30da4698a611b83 plugin=datadog |
Member
|
/gen sha=a6d78ad5b656c348f6dafbaefda95997fda3ced1 plugin=datadog |
…oudquery into feat/datadog_plugin_resources
kodiakhq bot
pushed a commit
that referenced
this pull request
Dec 1, 2022
🤖 I have created a release *beep* *boop* --- ## 1.0.0 (2022-12-01) ### Features * Adds datadog plugin resources ([#5192](#5192)) ([bc0c7e3](bc0c7e3)) * Datadog plugin ([#5096](#5096)) ([4c96026](4c96026)) * **website:** Add plugins tables ([#5259](#5259)) ([c336f4e](c336f4e)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.10.0 ([#5258](#5258)) ([a14640b](a14640b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds datadog resources as part of #4794 implementation