fix: Delete stale entries only for tables selected in config#5098
Merged
kodiakhq[bot] merged 14 commits intomainfrom Nov 30, 2022
Merged
fix: Delete stale entries only for tables selected in config#5098kodiakhq[bot] merged 14 commits intomainfrom
kodiakhq[bot] merged 14 commits intomainfrom
Conversation
disq
reviewed
Nov 25, 2022
yevgenypats
suggested changes
Nov 29, 2022
cli/cmd/migrate.go
Outdated
| fmt.Println("Starting migration for:", sourceSpec.Name, "->", sourceSpec.Destinations) | ||
| log.Info().Str("source", sourceSpec.Name).Strs("destinations", sourceSpec.Destinations).Msg("Starting migration") | ||
| tables, err := sourceClient.GetTables(ctx) | ||
| tables, _, err := getTablesForSpec(ctx, sourceClient, sourceSpec) |
Contributor
There was a problem hiding this comment.
I think we don't want to call this here (yet).
yevgenypats
approved these changes
Nov 29, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 30, 2022
🤖 I have created a release *beep* *boop* --- ## [2.0.22](cli-v2.0.21...cli-v2.0.22) (2022-11-30) ### Bug Fixes * Delete stale entries only for tables selected in config ([#5098](#5098)) ([801e42e](801e42e)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v1.10.0 ([#5153](#5153)) ([ea1f77e](ea1f77e)) * **deps:** Update plugin-sdk for cli to v1.8.1 ([#5034](#5034)) ([b9de28f](b9de28f)) * **deps:** Update plugin-sdk for cli to v1.8.2 ([#5076](#5076)) ([cab8860](cab8860)) * **deps:** Update plugin-sdk for cli to v1.9.0 ([#5095](#5095)) ([5d8658c](5d8658c)) * Fix spacing in Sync message ([#5091](#5091)) ([95511fc](95511fc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on this plugin-sdk change: cloudquery/plugin-sdk#440
Fixes #4770