feat(azure)!: Move Azure source plugin to SDK v2#4768
feat(azure)!: Move Azure source plugin to SDK v2#4768candiduslynx wants to merge 3 commits intomainfrom
Conversation
|
I had a look at the draft so far, looks good! 👍 |
3851590 to
375af35
Compare
8aa19f5 to
9681330
Compare
9681330 to
6a613ca
Compare
There was a problem hiding this comment.
Given it's a huge PR and I don't have the whole context.
Can you please link to the Issue of what this PR does and if the issue doesn't have enough description can you please link to the old SDK docs and the new SDK docs describing when they are being deprecated and so on.
erezrokah
left a comment
There was a problem hiding this comment.
Thanks for the PR @candiduslynx.
Haven't dived too much into the code yet, but I'm wondering about:
- Looks like we're still missing quite a lot of resources. Do we plan on adding those?
- It seems we could make this mostly non breaking by dropping the
properties_prefix, so most table changes will be adding new columns - Could we make the switch to the new SDK incrementally based on users' request? Is there a need to migrate everything now? I think that makes it hard to know if we missed anything
plugins/source/azure/docs/tables/azure_authorization_role_definitions.md
Outdated
Show resolved
Hide resolved
|
Also, looks like |
07f2d0b to
1a617c4
Compare
b86af41 to
802f25f
Compare
6da2fbe to
458ca87
Compare
|
I'll update the code once cloudquery/plugin-sdk#447 is merged, too |
yevgenypats
left a comment
There was a problem hiding this comment.
Great job! Let's put this and everything related (including policies) now on freeze until early next week as I need time to review now.
f521ec4 to
e722d99
Compare
This PR has the following changes to source plugin(s) tables:
|
234c6b6 to
288f6be
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
2cc1c0b to
5018522
Compare
524bf39 to
7c58e8b
Compare
|
We can close this in favour of #5350 |
Summary
Upgrade Azure plugin to new SDK (#1358)