Skip to content

feat: Use redacted errors for sentry/telemetry#461

Merged
disq merged 6 commits intocloudquery:mainfrom
disq:feat/use-redactions
Feb 3, 2022
Merged

feat: Use redacted errors for sentry/telemetry#461
disq merged 6 commits intocloudquery:mainfrom
disq:feat/use-redactions

Conversation

@disq
Copy link
Copy Markdown
Member

@disq disq commented Feb 2, 2022

No description provided.

@github-actions github-actions bot added the feat label Feb 2, 2022
@disq disq requested a review from roneli February 2, 2022 12:23
@github-actions github-actions bot added feat and removed feat labels Feb 2, 2022
@disq disq force-pushed the feat/use-redactions branch from 5701d71 to b2a05f6 Compare February 2, 2022 14:02
@github-actions github-actions bot added feat and removed feat labels Feb 2, 2022
Copy link
Copy Markdown
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roneli
Copy link
Copy Markdown
Contributor

roneli commented Feb 3, 2022

Do we want to squash diagnostics before sending them ?

@disq disq merged commit fbf5fb9 into cloudquery:main Feb 3, 2022
@disq disq deleted the feat/use-redactions branch February 3, 2022 11:37
TinLe pushed a commit to TinLe/cloudquery that referenced this pull request Feb 8, 2022
* upstream/main:
  docs: Add link to the 'Getting Started with Azure' guide (cloudquery#479)
  feat: Add max_goroutines to providers (cloudquery#477)
  feat: Use provider name/version as exception type when reporting diagnostics to Sentry (cloudquery#475)
  chore: Created local '.github/dependabot.yml' from remote 'dependabot.yml' (cloudquery#478)
  feat: Fetch only specified providers/resources (cloudquery#468)
  fix: Max parallel resource limit (cloudquery#471)
  fix: Update SDK, report squashed diagnostics (cloudquery#467)
  docs: Replace 'Getting Started' section of readme with link to the docs (cloudquery#464)
  fix: Policy Describe command  (cloudquery#466)
  fix: Empty source in provider (cloudquery#465)
  feat: Use redacted errors for sentry/telemetry (cloudquery#461)
erezrokah pushed a commit that referenced this pull request Aug 14, 2022
Changing order type vs. const to get cloudquery/cq-provider-gcp#460 to pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants