feat: Small improvements#459
Merged
disq merged 5 commits intocloudquery:mainfrom Feb 2, 2022
irmatov:small_improvements
Merged
feat: Small improvements#459disq merged 5 commits intocloudquery:mainfrom irmatov:small_improvements
disq merged 5 commits intocloudquery:mainfrom
irmatov:small_improvements
Conversation
disq
requested changes
Feb 1, 2022
| Logger: logging.NewZHcLog(&zerolog.Logger, ""), | ||
| url: url, | ||
| providers: make(map[string]ProviderDetails), | ||
| PluginDirectory: filepath.Join(".", ".cq", "providers"), |
Contributor
Author
There was a problem hiding this comment.
Right, I'll do a rebase
Contributor
Author
There was a problem hiding this comment.
Ehm, looks like at least for this PR purposes there is no change.
* introduce ProviderRepoName function * drop unused Hub.getLatestReleaseVersion
Rewrite the test so that it does not depend on database availability and network access to a git repo.
disq
approved these changes
Feb 2, 2022
TinLe
pushed a commit
to TinLe/cloudquery
that referenced
this pull request
Feb 2, 2022
* upstream/main: feat: Small improvements (cloudquery#459)
This was referenced May 10, 2022
erezrokah
pushed a commit
that referenced
this pull request
Aug 14, 2022
Synced local file(s) with [cloudquery/.github](https://github.com/cloudquery/.github). --- This PR was created automatically by the [repo-file-sync-action](https://github.com/BetaHuhn/repo-file-sync-action) workflow run [#2774614062](https://github.com/cloudquery/.github/actions/runs/2774614062)
erezrokah
pushed a commit
that referenced
this pull request
Aug 14, 2022
🤖 I have created a release *beep* *boop* --- ## [0.12.4](cloudquery/cq-provider-azure@v0.12.3...v0.12.4) (2022-08-07) ### Bug Fixes * **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.14.7 ([#458](cloudquery/cq-provider-azure#458)) ([39c0907](cloudquery/cq-provider-azure@39c0907)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite the test so that it does not depend on database availability
and network access to a git repo.