Merged
Conversation
implements cloudquery#446.
roneli
approved these changes
Feb 1, 2022
Contributor
roneli
left a comment
There was a problem hiding this comment.
LGTM, agree we should deprecate plugin/policy dir or default them to data-dir/policies|plugin if the flag isn't given. Docs need update PR.
Member
Author
|
@roneli so, I'll make those two options hidden and empty... if empty, it'll default to datadir/[policies|providers]. wdyt? |
TinLe
pushed a commit
to TinLe/cloudquery
that referenced
this pull request
Feb 2, 2022
* upstream/main: (25 commits) fix: Relax tfstate version check (cloudquery#460) fix: Use provider source (cloudquery#458) feat: Configurable data folder (cloudquery#456) chore: remove duplicate lint workflow (cloudquery#454) chore: Synced local '.github/workflows/' with remote 'workflows/common' (cloudquery#453) docs: Small fixes (cloudquery#452) chore: Remove extra linter workflow (cloudquery#451) fix: Getter implementation (cloudquery#450) fix: DB version validation shouldn't block on vanilla PG (cloudquery#447) fix: Validate provider semantic version (cloudquery#445) feat: Remove filtering from executor (cloudquery#429) fix: Panic when canceled (cloudquery#443) fix: Nil connection (cloudquery#442) feat: Update drift for AWS IOT resources (cloudquery#434) fix: Typo in error message (cloudquery#441) feat: Report on multiple aliased providers (cloudquery#437) fix: Refer to cloudquery as cloudquery (cloudquery#440) fix: Panic On Policy Describe (cloudquery#438) feat: Update SDK v0.7.0 (cloudquery#435) fix: Don't connect on cloudquery init (cloudquery#436) ...
This was referenced May 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #446.
Little bit too much. Maybe migrate away from plugin-dir and policy-dir in the future