Merged
Conversation
spangenberg
approved these changes
Jan 26, 2022
roneli
suggested changes
Jan 26, 2022
Contributor
roneli
left a comment
There was a problem hiding this comment.
Good catch, but this is a band aid fix, we can merge it, but I think the user should get an appropriate message or handling if we cancelled.
pkg/ui/console/client.go
Outdated
| return err | ||
| } | ||
|
|
||
| if response == nil { |
Contributor
There was a problem hiding this comment.
I think this is the wrong fix, so if we got cancelled we don't want to print fetch complete, probably fetch cancelled. (talking about L:145, should if there). Moreover, we might need to improve the fetch cancel to still return what was finished and mark the rest cancelled in the client's Fetch but that is a bigger PR.
Member
Author
There was a problem hiding this comment.
Fixed, I'm not sure if that's OK or we should return error (if failOnError is true maybe? so that error code is not affected?)
TinLe
pushed a commit
to TinLe/cloudquery
that referenced
this pull request
Feb 2, 2022
* upstream/main: (25 commits) fix: Relax tfstate version check (cloudquery#460) fix: Use provider source (cloudquery#458) feat: Configurable data folder (cloudquery#456) chore: remove duplicate lint workflow (cloudquery#454) chore: Synced local '.github/workflows/' with remote 'workflows/common' (cloudquery#453) docs: Small fixes (cloudquery#452) chore: Remove extra linter workflow (cloudquery#451) fix: Getter implementation (cloudquery#450) fix: DB version validation shouldn't block on vanilla PG (cloudquery#447) fix: Validate provider semantic version (cloudquery#445) feat: Remove filtering from executor (cloudquery#429) fix: Panic when canceled (cloudquery#443) fix: Nil connection (cloudquery#442) feat: Update drift for AWS IOT resources (cloudquery#434) fix: Typo in error message (cloudquery#441) feat: Report on multiple aliased providers (cloudquery#437) fix: Refer to cloudquery as cloudquery (cloudquery#440) fix: Panic On Policy Describe (cloudquery#438) feat: Update SDK v0.7.0 (cloudquery#435) fix: Don't connect on cloudquery init (cloudquery#436) ...
This was referenced May 10, 2022
erezrokah
pushed a commit
that referenced
this pull request
Aug 14, 2022
…11.28 (#443) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/Azure/go-autorest/autorest](https://togithub.com/Azure/go-autorest) | require | patch | `v0.11.27` -> `v0.11.28` | --- ### Release Notes <details> <summary>Azure/go-autorest</summary> ### [`v0.11.28`](https://togithub.com/Azure/go-autorest/releases/tag/autorest%2Fv0.11.28) [Compare Source](https://togithub.com/Azure/go-autorest/compare/autorest/v0.11.27...autorest/v0.11.28) Update crypto dependency to latest version [#​708](https://togithub.com/Azure/go-autorest/issues/708) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 3am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMzMuMCIsInVwZGF0ZWRJblZlciI6IjMyLjEzMy4wIn0=-->
erezrokah
pushed a commit
that referenced
this pull request
Aug 14, 2022
🤖 I have created a release *beep* *boop* --- ## [0.12.3](cloudquery/cq-provider-azure@v0.12.2...v0.12.3) (2022-08-07) ### Features * Add support for Tenants ([#412](cloudquery/cq-provider-azure#412)) ([940af7f](cloudquery/cq-provider-azure@940af7f)) ### Bug Fixes * **deps:** Update module github.com/Azure/go-autorest/autorest to v0.11.28 ([#443](cloudquery/cq-provider-azure#443)) ([bc87594](cloudquery/cq-provider-azure@bc87594)) * **deps:** Update module github.com/cloudquery/cq-gen to v0.0.7 ([#453](cloudquery/cq-provider-azure#453)) ([361d908](cloudquery/cq-provider-azure@361d908)) * **deps:** Update module github.com/cloudquery/cq-gen to v0.0.8 ([#457](cloudquery/cq-provider-azure#457)) ([7d61851](cloudquery/cq-provider-azure@7d61851)) * **deps:** Update module github.com/hashicorp/go-hclog to v1.2.2 ([#444](cloudquery/cq-provider-azure#444)) ([6c769c9](cloudquery/cq-provider-azure@6c769c9)) * **deps:** Update tubone24/update_release digest to 2146f15 ([#389](cloudquery/cq-provider-azure#389)) ([e5682fd](cloudquery/cq-provider-azure@e5682fd)) * **docs:** Some minor docs fixes ([#454](cloudquery/cq-provider-azure#454)) ([6feb015](cloudquery/cq-provider-azure@6feb015)) * **tests:** Remove terraform for Azure ExpressRoute port ([#440](cloudquery/cq-provider-azure#440)) ([7413740](cloudquery/cq-provider-azure@7413740)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.