feat(aws): More SSM resources#4381
Merged
kodiakhq[bot] merged 5 commits intocloudquery:mainfrom Nov 16, 2022
Merged
Conversation
3 tasks
hermanschaaf
approved these changes
Nov 15, 2022
Contributor
hermanschaaf
left a comment
There was a problem hiding this comment.
LGTM 👍 I think we can always start here and then use the the Describe...-type calls later if it turns out they are required by some users.
erezrokah
approved these changes
Nov 15, 2022
bbernays
approved these changes
Nov 15, 2022
Collaborator
bbernays
left a comment
There was a problem hiding this comment.
LGTM... I think DescribeInstancePatchStates is just a relation for instance_patches so shouldn't be that bad
Member
Author
|
Maybe merge for now and see it in the field vs. customer requirements/issues? |
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 16, 2022
🤖 I have created a release *beep* *boop* --- ## [6.2.0](plugins-source-aws-v6.1.0...plugins-source-aws-v6.2.0) (2022-11-16) ### Features * **aws:** Add Support for Eventbridge scheduler ([#4693](#4693)) ([a4ef661](a4ef661)) * **aws:** More SSM resources ([#4381](#4381)) ([42b0c70](42b0c70)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully implements #1409
I'm not sure if this is enough or if we need more (
DescribeInstancePatchStatesfor instance... which can take multiple InstanceIds as input, so challenges ahead)