feat: Increase ulimit in unix environment#416
Conversation
yevgenypats
left a comment
There was a problem hiding this comment.
Great. I think this should work - I've one questions regarding initialization and if you were able to test it that it also sets the ulimit for child process (I think it should but would double verify it manually).
| const ulimitUnix uint64 = 16384 | ||
|
|
||
| func init() { | ||
| fileDescriptorF = checkAndSetUlimitUnix |
There was a problem hiding this comment.
why we can call checkAndSetUlimitUnix directly ? This should also remove the need for this check unless Im missing some edge-case
There was a problem hiding this comment.
It should fail on windows if I'm not completely mistaken. Since syscall is not available.
yevgenypats
left a comment
There was a problem hiding this comment.
ok I see now regarding the initialization, it is because of the build tags. Can you add a small comment for that.
|
@spangenberg can you only fix that the commit will be the same as the pr title (it's when there is one commit, GitHub is using the commit instead of the PR Title and it doesn't have the |
|
Sure, will take care about that and the extended manual testing. |
bae19f4 to
030970c
Compare
|
The PR was manually tested on MacOS, Linux and Windows. |
* upstream/main: chore: Synced local '.github/workflows/' with remote 'workflows/common' (cloudquery#421) fix: Don't show telemetry notice when it's not enabled (cloudquery#418) feat: Increase ulimit in unix environment (cloudquery#416) feat: Support build-schema for all providers in config (cloudquery#414) fix: Fetch summary fixes (cloudquery#417) feat: Added store fetch summary routine (cloudquery#356) chore: Synced file(s) with cloudquery/.github (cloudquery#415) feat: Expose max_parallel_resource_fetch_limit (cloudquery#413) feat: Adjust log messages when .cq dir is absent (cloudquery#411) fix: Adjust policy describe message (cloudquery#409) fix: Exit with 1 on policy error (cloudquery#412)
Co-authored-by: Renovate Bot <renovate@whitesourcesoftware.com>
Add Azure Front Door CDN resource
The ulimit in Unix environment will be increased automatically.
Currently, we fail a lot of runs due to low limits.
In case of an error, we just log and continue.