Skip to content

feat: Support build-schema for all providers in config#414

Merged
yevgenypats merged 4 commits intomainfrom
feat/build_schema_all_providers
Jan 18, 2022
Merged

feat: Support build-schema for all providers in config#414
yevgenypats merged 4 commits intomainfrom
feat/build_schema_all_providers

Conversation

@yevgenypats
Copy link
Copy Markdown
Contributor

No description provided.

@yevgenypats yevgenypats requested a review from roneli January 15, 2022 19:35
@yevgenypats yevgenypats force-pushed the feat/build_schema_all_providers branch from 0c18c7b to 7876e2d Compare January 18, 2022 07:50
Copy link
Copy Markdown
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor nit

cmd/provider.go Outdated
Comment on lines +81 to +82
} else {
return c.BuildAllProviderTables(ctx)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for else

@yevgenypats yevgenypats merged commit ad1ae13 into main Jan 18, 2022
@yevgenypats yevgenypats deleted the feat/build_schema_all_providers branch January 18, 2022 08:47
TinLe pushed a commit to TinLe/cloudquery that referenced this pull request Jan 19, 2022
* upstream/main:
  chore: Synced local '.github/workflows/' with remote 'workflows/common' (cloudquery#421)
  fix: Don't show telemetry notice when it's not enabled (cloudquery#418)
  feat: Increase ulimit in unix environment (cloudquery#416)
  feat: Support build-schema for all providers in config (cloudquery#414)
  fix: Fetch summary fixes (cloudquery#417)
  feat: Added store fetch summary routine (cloudquery#356)
  chore: Synced file(s) with cloudquery/.github (cloudquery#415)
  feat: Expose max_parallel_resource_fetch_limit (cloudquery#413)
  feat: Adjust log messages when .cq dir is absent (cloudquery#411)
  fix: Adjust policy describe message (cloudquery#409)
  fix: Exit with 1 on policy error (cloudquery#412)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants