Merged
Conversation
Remove confusing and unused flags: stop-on-failure fail-on-violations
TinLe
pushed a commit
to TinLe/cloudquery
that referenced
this pull request
Jan 19, 2022
* upstream/main: chore: Synced local '.github/workflows/' with remote 'workflows/common' (cloudquery#421) fix: Don't show telemetry notice when it's not enabled (cloudquery#418) feat: Increase ulimit in unix environment (cloudquery#416) feat: Support build-schema for all providers in config (cloudquery#414) fix: Fetch summary fixes (cloudquery#417) feat: Added store fetch summary routine (cloudquery#356) chore: Synced file(s) with cloudquery/.github (cloudquery#415) feat: Expose max_parallel_resource_fetch_limit (cloudquery#413) feat: Adjust log messages when .cq dir is absent (cloudquery#411) fix: Adjust policy describe message (cloudquery#409) fix: Exit with 1 on policy error (cloudquery#412)
This was referenced May 10, 2022
erezrokah
pushed a commit
that referenced
this pull request
Aug 14, 2022
As requested in cloudquery/cq-provider-azure#406, this adds support for listing tenants under a subscription. It can be used by adding `subscriptions.tenant` to the cloudquery config, which will then populate a table named `azure_subscription_tenants`. To add this, we had to start using the new `armsubscriptions` Azure SDK, which requires Go 1.18 and uses generics. The implementation for the subscriptions client has been switched to use this now. The benefit of this is that we also get new columns and relations on the `accounts` and `subscriptions` tables. Tables updated in this PR: - `azure_account_location_paired_region` (new) - `azure_account_locations` (new columns) - `azure_subscription_subscriptions` (new columns, notably `tenant_id` and `managed_by_tenants`) - `azure_subscription_tenants` (new) Closes cloudquery/cq-provider-azure#406
erezrokah
pushed a commit
that referenced
this pull request
Aug 14, 2022
🤖 I have created a release *beep* *boop* --- ## [0.12.3](cloudquery/cq-provider-azure@v0.12.2...v0.12.3) (2022-08-07) ### Features * Add support for Tenants ([#412](cloudquery/cq-provider-azure#412)) ([940af7f](cloudquery/cq-provider-azure@940af7f)) ### Bug Fixes * **deps:** Update module github.com/Azure/go-autorest/autorest to v0.11.28 ([#443](cloudquery/cq-provider-azure#443)) ([bc87594](cloudquery/cq-provider-azure@bc87594)) * **deps:** Update module github.com/cloudquery/cq-gen to v0.0.7 ([#453](cloudquery/cq-provider-azure#453)) ([361d908](cloudquery/cq-provider-azure@361d908)) * **deps:** Update module github.com/cloudquery/cq-gen to v0.0.8 ([#457](cloudquery/cq-provider-azure#457)) ([7d61851](cloudquery/cq-provider-azure@7d61851)) * **deps:** Update module github.com/hashicorp/go-hclog to v1.2.2 ([#444](cloudquery/cq-provider-azure#444)) ([6c769c9](cloudquery/cq-provider-azure@6c769c9)) * **deps:** Update tubone24/update_release digest to 2146f15 ([#389](cloudquery/cq-provider-azure#389)) ([e5682fd](cloudquery/cq-provider-azure@e5682fd)) * **docs:** Some minor docs fixes ([#454](cloudquery/cq-provider-azure#454)) ([6feb015](cloudquery/cq-provider-azure@6feb015)) * **tests:** Remove terraform for Azure ExpressRoute port ([#440](cloudquery/cq-provider-azure#440)) ([7413740](cloudquery/cq-provider-azure@7413740)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove confusing and unused flags:
stop-on-failure
fail-on-violations
Reasoning:
If there is an internal error such as incorrect version, missing tables, there is no reason really to not stop, so this just creates additional documentation and not-intuitive default behaviour (such as not returning 1 on internal error)
stop-on-failure- policies run very fast so I would eliminate that flag as well, just have a default behaviour that shows all the results.Why I started it:
In the CI we always had to add special flags to detect errors and sometimes we missed errors because the CI didn't fail on internal errors.