Skip to content

Don't check for update if development build#382

Merged
yevgenypats merged 4 commits intocloudquery:mainfrom
disq:fix/no-update-check-for-devel
Jan 3, 2022
Merged

Don't check for update if development build#382
yevgenypats merged 4 commits intocloudquery:mainfrom
disq:fix/no-update-check-for-devel

Conversation

@disq
Copy link
Copy Markdown
Member

@disq disq commented Jan 3, 2022

This prevents the warning-level log

@disq disq requested review from irmatov and roneli January 3, 2022 12:46
@disq disq force-pushed the fix/no-update-check-for-devel branch from 1239d34 to 728cef5 Compare January 3, 2022 13:17
Copy link
Copy Markdown
Contributor

@yevgenypats yevgenypats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit unrelated to this PR but the DefaultVersion confused me a bit. can we name it DevelopmentVersion ?

@disq
Copy link
Copy Markdown
Member Author

disq commented Jan 3, 2022

A bit unrelated to this PR but the DefaultVersion confused me a bit. can we name it DevelopmentVersion ?

Good idea, done

@yevgenypats yevgenypats merged commit 34dca4c into cloudquery:main Jan 3, 2022
@disq disq deleted the fix/no-update-check-for-devel branch January 3, 2022 14:50
erezrokah pushed a commit that referenced this pull request Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants