fix: Optionally send --no-sentry when using managed plugins#3762
Merged
kodiakhq[bot] merged 5 commits intomainfrom Nov 8, 2022
Merged
fix: Optionally send --no-sentry when using managed plugins#3762kodiakhq[bot] merged 5 commits intomainfrom
kodiakhq[bot] merged 5 commits intomainfrom
Conversation
…sentry-on-plugins
disq
approved these changes
Nov 8, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 9, 2022
🤖 I have created a release *beep* *boop* --- ## [2.0.4](cli-v2.0.3...cli-v2.0.4) (2022-11-09) ### Bug Fixes * Optionally send --no-sentry when using managed plugins ([#3762](#3762)) ([ac93ddf](ac93ddf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
SCKelemen
pushed a commit
to SCKelemen/cloudquery
that referenced
this pull request
Nov 15, 2022
…ry#3762) This fixes a bug where panics in plugins would be sent to Sentry even though telemetry-level was set to `none` at the CLI level. Related PR: cloudquery/plugin-sdk#363
SCKelemen
pushed a commit
to SCKelemen/cloudquery
that referenced
this pull request
Nov 15, 2022
🤖 I have created a release *beep* *boop* --- ## [2.0.4](cloudquery/cloudquery@cli-v2.0.3...cli-v2.0.4) (2022-11-09) ### Bug Fixes * Optionally send --no-sentry when using managed plugins ([cloudquery#3762](cloudquery#3762)) ([ac93ddf](cloudquery@ac93ddf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where panics in plugins would be sent to Sentry even though telemetry-level was set to
noneat the CLI level.Related PR: cloudquery/plugin-sdk#363