fix: Fix bug in s3_cross_region_replication policy#3565
Merged
kodiakhq[bot] merged 2 commits intomainfrom Nov 4, 2022
Merged
Conversation
disq
approved these changes
Nov 4, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 6, 2022
🤖 I have created a release *beep* *boop* --- ## [4.6.0](plugins-source-aws-v4.5.0...plugins-source-aws-v4.6.0) (2022-11-06) ### Features * AppRunner add support for Connections ([#3602](#3602)) ([b6c17a2](b6c17a2)) * **aws:** AppRunner Resources: VPC Connector, VPC Ingress Connection And Autotscaling ([#3450](#3450)) ([f5cd42c](f5cd42c)) * **aws:** AppRunner support ObservabilityConfiguration ([#3603](#3603)) ([b93a66d](b93a66d)) * **aws:** Support identitystore and ssoadmin ([#3005](#3005)) ([afa463d](afa463d)) ### Bug Fixes * **aws:** Elasticache Engine Versions PK ([#3562](#3562)) ([59a7400](59a7400)), closes [#3561](#3561) * **deps:** Update plugin-sdk for aws to v0.13.20 ([#3569](#3569)) ([3876311](3876311)) * Fix bug in s3_cross_region_replication policy ([#3565](#3565)) ([515a7d0](515a7d0)) * Fix documentation ([#3608](#3608)) ([ea14f06](ea14f06)) * Update endpoints ([#3605](#3605)) ([20b9f4f](20b9f4f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3563
There is a wider question here about whether we should be placing null values in the column at all--maybe they should be empty arrays instead. But for now this change fixes this specific policy.