fix(aws-code-gen): Prefix service name when filtering relations from table list#3546
Merged
erezrokah merged 2 commits intocloudquery:mainfrom Nov 3, 2022
Merged
Conversation
16a2485 to
d1f4400
Compare
erezrokah
pushed a commit
that referenced
this pull request
Nov 3, 2022
🤖 I have created a release *beep* *boop* --- ## [4.3.0](plugins-source-aws-v4.2.1...plugins-source-aws-v4.3.0) (2022-11-03) ### Features * **aws:** Add Support for Service Quotas ([#3489](#3489)) ([d9d0dac](d9d0dac)) * **aws:** Managed Workflows for Apache Airflow (MWAA) environments ([#3431](#3431)) ([a8a08c3](a8a08c3)), closes [#2300](#2300) ### Bug Fixes * **aws-code-gen:** Prefix service name when filtering relations from table list ([#3546](#3546)) ([aefaa9a](aefaa9a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We're missing a bunch of top level tables, as if there's a relation function named "Instances" it will also filter a top level "Instances" service.
See tables for v4.0.0:
https://github.com/cloudquery/cloudquery/blob/plugins-source-aws-v4.0.0/plugins/source/aws/resources/plugin/tables.go#L145
See tables for v4.2.1:
https://github.com/cloudquery/cloudquery/blob/plugins-source-aws-v4.2.1/plugins/source/aws/resources/plugin/tables.go#L146