Skip to content

chore(ci): Generate code and docs for dependencies updates#3346

Merged
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
erezrokah:chore/sync_code_docs_sdk_updates
Nov 3, 2022
Merged

chore(ci): Generate code and docs for dependencies updates#3346
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
erezrokah:chore/sync_code_docs_sdk_updates

Conversation

@erezrokah
Copy link
Copy Markdown
Member

@erezrokah erezrokah changed the title chore(ci): Gen code for dependecies updates chore(ci): Generate code and docs for dependencies updates Oct 31, 2022
// e.g. plugins/source/aws/go.mod
const plugin = goModFile.split('/')[2]
console.log({ issue_number, owner, repo, sha, plugin });
await github.rest.issues.createComment({
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment triggers the /gen command for this plugin (to re-use that workflow)

@erezrokah erezrokah requested a review from bbernays October 31, 2022 15:13
@yevgenypats
Copy link
Copy Markdown
Contributor

Can we just rigger this the same way as we do with docs and linters and see if anything changed ?

@bbernays
Copy link
Copy Markdown
Collaborator

Can we just rigger this the same way as we do with docs and linters and see if anything changed ?

If we do that, then as soon as package update is released then the next pr will have to update (even if it is for a completely different resource)

@erezrokah
Copy link
Copy Markdown
Member Author

erezrokah commented Oct 31, 2022

Can we just rigger this the same way as we do with docs and linters and see if anything changed ?

I think that would make our workflows a bit complex, see just AWS https://github.com/cloudquery/cloudquery/compare/main...erezrokah:chore/update_code_docs_prs?expand=1

And this is also missing the check for branch name logic.

The complexity comes from needing to use a personal access token otherwise the new commit won't trigger the CI (built in GitHub token limitation). So we need to support both forked workflows (where we can't use an elevated token) and a non forked workflows

Copy link
Copy Markdown
Contributor

@hermanschaaf hermanschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to try it

@erezrokah erezrokah added the automerge Automatically merge once required checks pass label Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(ci): Run code gen and doc gen on services API updates

4 participants