Merged
Conversation
erezrokah
approved these changes
Oct 16, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 16, 2022
🤖 I have created a release *beep* *boop* --- ## [3.0.1](plugins-source-aws-v3.0.0...plugins-source-aws-v3.0.1) (2022-10-16) ### Bug Fixes * Add codegen for AWS regions ([#2701](#2701)) ([9b1b2ca](9b1b2ca)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found another case of an AWS resource not being generated with codegen. It was unfortunately not so easy to deal with this one in a backwards-compatible way. The biggest issue is keeping the name
aws_regionsrather thanaws_ec2_regions(which would be in line with all other resources).Note: This could perhaps be considered a
chore, as it should change no user-facing functionality, but since there is a small change in the ordering of the columns I think I'd rather have it reported as one of the changes in the next release.