fix!: Rename domains c_name to cname#2635
Merged
erezrokah merged 4 commits intocloudquery:mainfrom Oct 11, 2022
Merged
Conversation
hermanschaaf
suggested changes
Oct 11, 2022
Contributor
hermanschaaf
left a comment
There was a problem hiding this comment.
Missing gen-code, otherwise LGTM 👍
hermanschaaf
approved these changes
Oct 11, 2022
Contributor
hermanschaaf
left a comment
There was a problem hiding this comment.
Nice, thanks for doing the refactoring work as well 👍
Member
Author
|
@hermanschaaf looks like another breaking change due to https://github.com/cloudquery/cloudquery/pull/2635/files#diff-f8e4debb63fb716d5f8829d87f8dbdc19564da7bc53b4d3481d6cade51593fab: |
c_name to cname
shimonp21
added a commit
that referenced
this pull request
Oct 12, 2022
🤖 I have created a release *beep* *boop* --- ## [2.0.0](plugins-source-heroku-v1.0.1...plugins-source-heroku-v2.0.0) (2022-10-12) ### ⚠ BREAKING CHANGES * Rename domains `c_name` to `cname` (#2635) ### Bug Fixes * **deps:** Update plugin-sdk for heroku to v0.12.10 ([#2551](#2551)) ([d0771ec](d0771ec)) * Rename domains `c_name` to `cname` ([#2635](#2635)) ([70ff2dc](70ff2dc)) * Upgrade source SDK versions to v0.13.5 ([#2610](#2610)) ([611868e](611868e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: shimonp21 <37939765+shimonp21@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #2189.
../resources/servicesfor consistency with other plugins (there's a follow up here to put each namespace in a separate directory, but didn't want to do too many changes)plugin/plugin.gotoresources/plugin/plugin.go. This is required so Go Releaser embeds the correct version of the plugin during release, seecloudquery/plugins/.goreleaser.yaml
Line 12 in 6ab0429