fix!: Use JSON tag for column names#2627
Merged
kodiakhq[bot] merged 3 commits intocloudquery:mainfrom Oct 11, 2022
Merged
Conversation
erezrokah
commented
Oct 11, 2022
| "text/template" | ||
|
|
||
| "github.com/cloudquery/cloudquery/plugins/source/cloudflare/codegenmain/recipes" | ||
| "github.com/cloudquery/cloudquery/plugins/source/cloudflare/codegen/recipes" |
Member
Author
There was a problem hiding this comment.
Renamed this package and moved the files to be consistent with other plugins
erezrokah
commented
Oct 11, 2022
| Name: "account_cq_id", | ||
| Type: schema.TypeUUID, | ||
| Resolver: "schema.ParentIDResolver", | ||
| Name: "account_id", |
Member
Author
There was a problem hiding this comment.
This was updated in the resources, but not in the code gen (I was the one who did this update and missed the code gen changes)
erezrokah
commented
Oct 11, 2022
| }, | ||
| { | ||
| Name: "require_signed_ur_ls", | ||
| Name: "require_signed_urls", |
erezrokah
commented
Oct 11, 2022
| }, | ||
| { | ||
| Name: "type", | ||
| Name: "secret_text", |
erezrokah
commented
Oct 11, 2022
| }, | ||
| { | ||
| Name: "dev_mode", | ||
| Name: "development_mode", |
Member
Author
There was a problem hiding this comment.
All breaking changes due to taking the column names from JSON tags
hermanschaaf
approved these changes
Oct 11, 2022
797bffb to
452f7a7
Compare
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 12, 2022
🤖 I have created a release *beep* *boop* --- ## [2.0.0](plugins-source-cloudflare-v1.0.1...plugins-source-cloudflare-v2.0.0) (2022-10-12) ### ⚠ BREAKING CHANGES * Use JSON tag for column names (#2627) ### Bug Fixes * **deps:** Update plugin-sdk for cloudflare to v0.12.10 ([#2547](#2547)) ([cf8216d](cf8216d)) * Upgrade source SDK versions to v0.13.5 ([#2610](#2610)) ([611868e](611868e)) * Use JSON tag for column names ([#2627](#2627)) ([9c98b5e](9c98b5e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #2189, extracted from #2623. Tests for code gen drift for the Cloudflare plugin.
This is a breaking change as it renames a few columns due to cloudquery/plugin-sdk#112