fix: Fixed crashes when json field is nil#2486
Merged
amanenk merged 3 commits intocloudquery:mainfrom Oct 6, 2022
Merged
Conversation
bbernays
reviewed
Oct 6, 2022
bbernays
requested changes
Oct 6, 2022
Collaborator
bbernays
left a comment
There was a problem hiding this comment.
Can you also add a test case to the SNS Subscriptions resolver that uncovered this whole issue?
Closed
hermanschaaf
approved these changes
Oct 6, 2022
bbernays
approved these changes
Oct 6, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 6, 2022
🤖 I have created a release *beep* *boop* --- ## [2.0.1](plugins-source-aws-v2.0.0...plugins-source-aws-v2.0.1) (2022-10-06) ### Bug Fixes * **aws:** Re-add Cloudtrail tags ([#2479](#2479)) ([c2857d5](c2857d5)) * **aws:** Re-add Route53 hosted zone tags ([#2480](#2480)) ([ebb9eb6](ebb9eb6)) * **aws:** Regen glue jobs ([#2476](#2476)) ([c787928](c787928)) * Fixed crashes when json field is nil ([#2486](#2486)) ([7dcda4f](7dcda4f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MarshaledJsonResolver was not able to handle nil fields