Merged
Conversation
roneli
approved these changes
Nov 5, 2021
Contributor
roneli
left a comment
There was a problem hiding this comment.
LGTM, can we also add tests to this PR ? to make sure it works and we don't get any regressions
yevgenypats
approved these changes
Nov 5, 2021
Contributor
yevgenypats
left a comment
There was a problem hiding this comment.
Tested locally and looks like it works. agree we should add the integration tests for this feature in this repository (in GitHub actions)
Contributor
|
@yevgenypats should also be possible to test with local unit tests |
erezrokah
pushed a commit
that referenced
this pull request
Aug 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #243
fixes #244
fixes cloudquery/cloudquery-issues#156