fix!: Store some JSON columns as jsonb not as a text#2463
Merged
amanenk merged 8 commits intocloudquery:mainfrom Oct 6, 2022
Merged
fix!: Store some JSON columns as jsonb not as a text#2463amanenk merged 8 commits intocloudquery:mainfrom
amanenk merged 8 commits intocloudquery:mainfrom
Conversation
hermanschaaf
reviewed
Oct 6, 2022
plugins/source/aws/resources/services/rds/db_security_groups.go
Outdated
Show resolved
Hide resolved
hermanschaaf
suggested changes
Oct 6, 2022
Contributor
hermanschaaf
left a comment
There was a problem hiding this comment.
LGTM, we just need to rebase and regenerate using latest main branch so the ec2 column name doesn't change
Contributor
|
@amanenk Could you also regenerate the docs again please 🙇 Looks like our workflow for detecting docs drift isn't working, I'll have to take a look at that |
hermanschaaf
reviewed
Oct 6, 2022
hermanschaaf
approved these changes
Oct 6, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 6, 2022
🤖 I have created a release *beep* *boop* --- ## [2.0.0](plugins-source-aws-v1.0.1...plugins-source-aws-v2.0.0) (2022-10-06) ### ⚠ BREAKING CHANGES * Update all AWS Client Versions (#2410) * Store some JSON columns as jsonb not as a text (#2463) ### Features * Add new fields to Lightsail and EC2 ([#2403](#2403)) ([7e3fc83](7e3fc83)) * **aws:** EMR Clusters to use PreResourceResolver ([#2411](#2411)) ([b01e6ca](b01e6ca)) * **aws:** Update cis 1.5.0 policy ([#1615](#1615)) ([0f64196](0f64196)) ### Bug Fixes * AWS codegen: fix ec2 naming ([#2473](#2473)) ([27dd558](27dd558)) * **deps:** Update plugin-sdk for aws to v0.12.3 ([#2383](#2383)) ([0ed4d5f](0ed4d5f)) * **deps:** Update plugin-sdk for aws to v0.12.4 ([#2394](#2394)) ([d8c9657](d8c9657)) * **deps:** Update plugin-sdk for aws to v0.12.6 ([#2416](#2416)) ([0539c03](0539c03)) * **deps:** Update plugin-sdk for aws to v0.12.7 ([#2445](#2445)) ([6e39611](6e39611)) * Store some JSON columns as jsonb not as a text ([#2463](#2463)) ([5da8a1f](5da8a1f)) * Update all AWS Client Versions ([#2410](#2410)) ([ca34f1c](ca34f1c)) * Update endpoints ([#2414](#2414)) ([62d8802](62d8802)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #2430