fix(cli): Close stdout when using --log-console#2459
Merged
kodiakhq[bot] merged 7 commits intomainfrom Oct 7, 2022
Merged
Conversation
when we use --log-console we dont want standard output. logs are by default written to stderr so we just close stdout which make any fmt.Print* silent. This makes it easy to use fmt.Print* in the CLI and not use any new abstractions and prop drilling.
kodiakhq bot
pushed a commit
to cloudquery/plugin-sdk
that referenced
this pull request
Oct 5, 2022
<!-- Explain what problem this PR addresses --> This PR and this cloudquery/cloudquery#2459 should ensure logs and stdout are not running over each other. The convention should be the following fmt.Print* -> stdout, logs -> stderr this way it's easy to turn off one stream or the other depending on the need
hermanschaaf
reviewed
Oct 6, 2022
hermanschaaf
reviewed
Oct 6, 2022
Co-authored-by: Herman Schaaf <hermanschaaf@gmail.com>
hermanschaaf
approved these changes
Oct 7, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 9, 2022
🤖 I have created a release *beep* *boop* --- ## [1.0.6](cli-v1.0.5...cli-v1.0.6) (2022-10-08) ### Bug Fixes * **cli:** Close stdout when using --log-console ([#2459](#2459)) ([264c493](264c493)) * **deps:** Update plugin-sdk for cli to v0.12.8 ([#2497](#2497)) ([33c0c46](33c0c46)) * **deps:** Update plugin-sdk for cli to v0.12.9 ([#2511](#2511)) ([6787155](6787155)) * Show sync time ([#2493](#2493)) ([014e8aa](014e8aa)) * SourceName ([#2522](#2522)) ([0b7db32](0b7db32)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when we use --log-console we dont want standard output. logs are by default written to stderr so we just close stdout which make any fmt.Print* silent. This makes it easy to use fmt.Print* in the CLI and not use any new abstractions and prop drilling.
This also adds handling of ctrl+c, that should go together with this as well cloudquery/plugin-sdk#252