fix(gcp): Re-add missing field in crypto_keys (rotation_period)#2132
Merged
disq merged 7 commits intocloudquery:mainfrom Oct 4, 2022
Merged
fix(gcp): Re-add missing field in crypto_keys (rotation_period)#2132disq merged 7 commits intocloudquery:mainfrom
disq merged 7 commits intocloudquery:mainfrom
Conversation
erezrokah
approved these changes
Sep 29, 2022
de94c82 to
1f6cb3d
Compare
Contributor
|
@disq can you please elaborate on what was the issue with the new API or even better add a comment so we wont try to change it to the new API in the future? |
Member
Author
@yevgenypats |
62c5245 to
2ea4a48
Compare
yevgenypats
approved these changes
Oct 4, 2022
2ea4a48 to
3e2a47a
Compare
3e2a47a to
0fe1c87
Compare
erezrokah
added a commit
that referenced
this pull request
Oct 4, 2022
🤖 I have created a release *beep* *boop* --- ## [1.0.0](plugins-source-gcp-v0.9.9...plugins-source-gcp-v1.0.0) (2022-10-04) ### ⚠ BREAKING CHANGES * Official v1 release (#2335) * CloudQuery V2. (#1463) ### Features * CloudQuery V2. ([#1463](#1463)) ([d1799f3](d1799f3)) * **gcp:** Remove Classify and IgnoreError ([#1757](#1757)) ([3d34ca5](3d34ca5)) * Generate auto-filled config ([#1764](#1764)) ([2255404](2255404)) * **postgresql:** Add support for overwrite-delete-stale ([#2220](#2220)) ([efdd136](efdd136)) ### Bug Fixes * **deps:** Update golang.org/x/sync digest to 7fc1605 ([#1652](#1652)) ([daafae1](daafae1)) * **deps:** Update google.golang.org/genproto digest to c98284e ([#2171](#2171)) ([e2b5c23](e2b5c23)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.1.2 ([#1750](#1750)) ([fbe1b78](fbe1b78)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.10.2 ([#2048](#2048)) ([e407991](e407991)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.11.0 ([#2135](#2135)) ([1729467](1729467)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.11.2 ([#2162](#2162)) ([5701aa5](5701aa5)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.11.4 ([#2213](#2213)) ([1ffc1dd](1ffc1dd)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.11.5 ([#2230](#2230)) ([bd79416](bd79416)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.2.4 ([#1761](#1761)) ([7a83a65](7a83a65)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.2.5 ([#1769](#1769)) ([c9c8c05](c9c8c05)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.2.6 ([#1770](#1770)) ([5bc205e](5bc205e)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.2.7 ([#1783](#1783)) ([c291499](c291499)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.2.8 ([#1784](#1784)) ([b64e2d1](b64e2d1)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.2.9 ([#1785](#1785)) ([c6e8cb0](c6e8cb0)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.4.0 ([#1786](#1786)) ([cba274b](cba274b)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.4.1 ([#1787](#1787)) ([bad385c](bad385c)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.4.2 ([#1789](#1789)) ([79a46a2](79a46a2)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.5.0 ([#1792](#1792)) ([0b4834e](0b4834e)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.5.2 ([#1793](#1793)) ([36fd6a1](36fd6a1)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.6.0 ([#1817](#1817)) ([bd68a9c](bd68a9c)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.6.1 ([#1820](#1820)) ([2613e23](2613e23)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.6.2 ([#1838](#1838)) ([5b16c59](5b16c59)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.6.3 ([#1858](#1858)) ([9e3ace7](9e3ace7)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.6.4 ([#1862](#1862)) ([5d141cf](5d141cf)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.1 ([#1865](#1865)) ([474bb70](474bb70)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.12 ([#1916](#1916)) ([27d8153](27d8153)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.2 ([#1872](#1872)) ([49ed26d](49ed26d)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.3 ([#1886](#1886)) ([7435d59](7435d59)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.7.4 ([#1889](#1889)) ([63a5362](63a5362)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.8.0 ([#1997](#1997)) ([4fa40da](4fa40da)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.8.1 ([#2024](#2024)) ([8f88de4](8f88de4)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.8.2 ([#2044](#2044)) ([9b69b46](9b69b46)) * **deps:** Update plugin-sdk for gcp to v0.11.6 ([#2256](#2256)) ([f148b3f](f148b3f)) * **deps:** Update plugin-sdk for gcp to v0.12.2 ([#2282](#2282)) ([e0b7ba4](e0b7ba4)) * Enable GCP to find all Active Projects ([#1782](#1782)) ([5348ad4](5348ad4)) * GCP policies ([#1879](#1879)) ([1591f9f](1591f9f)) * **gcp:** Re-add gcp_iam_service_account_keys ([#2134](#2134)) ([8f419c3](8f419c3)), closes [#1990](#1990) * **gcp:** Re-add missing field in crypto_keys (rotation_period) ([#2132](#2132)) ([558ed75](558ed75)) * Naming fixes in gcp plugin ([#1903](#1903)) ([eb6ec00](eb6ec00)) * Re-add GCP project policies ([#2108](#2108)) ([1253568](1253568)), closes [#1989](#1989) * Remove unused codegen fields in GCP ([#2109](#2109)) ([f9acf5d](f9acf5d)) * Run tinypng on GCP dashboard screenshots ([#2274](#2274)) ([a2b662c](a2b662c)) * Update all source plugin to v0.12.2 ([#2316](#2316)) ([5099dcf](5099dcf)) * Used DefaultTransformer from plugin-sdk for name transformations ([#1943](#1943)) ([716ff8e](716ff8e)) ### Miscellaneous Chores * Official v1 release ([#2335](#2335)) ([e32de23](e32de23)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: erezrokah <erezrokah@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1995
Had to use the old KMS api to make it work.