feat: Add per table stats to sync summaries#21107
Merged
kodiakhq[bot] merged 7 commits intomainfrom Jul 24, 2025
Merged
Conversation
erezrokah
commented
Jul 24, 2025
| SyncGroupID *string `json:"sync_group_id,omitempty"` | ||
| ShardNum *int `json:"shard_num,omitempty"` | ||
| ShardTotal *int `json:"shard_total,omitempty"` | ||
| ResourcesPerTable map[string]uint64 `json:"resources_per_table,omitempty"` |
Member
Author
There was a problem hiding this comment.
Went with 2 separate columns as it's aligned with resources, source_errors and destination_errors.
Also a map is easier to query on some databases (if I used a single column it will be a JSON column in most destinations)
erezrokah
commented
Jul 24, 2025
| ShardNum *int `json:"shard_num,omitempty"` | ||
| ShardTotal *int `json:"shard_total,omitempty"` | ||
| ResourcesPerTable map[string]uint64 `json:"resources_per_table,omitempty"` | ||
| ErrorsPerTable map[string]uint64 `json:"errors_per_table,omitempty"` |
Member
Author
There was a problem hiding this comment.
We can also do source_errors_per_table but I think it's clear these errors are from the source
disq
approved these changes
Jul 24, 2025
stoovon
approved these changes
Jul 24, 2025
be78f99 to
a77d1c2
Compare
16faf30 to
5732305
Compare
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 24, 2025
🤖 I have created a release *beep* *boop* --- ## [6.25.0](cli-v6.24.2...cli-v6.25.0) (2025-07-24) ### Features * Add per table stats to sync summaries ([#21107](#21107)) ([0cbe42f](0cbe42f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds per table stats for the sync summaries table (we already have total
resourcesandsource_errors)