fix(deps): Update module github.com/cloudquery/plugin-sdk/v4 to v4.87.3#21064
fix(deps): Update module github.com/cloudquery/plugin-sdk/v4 to v4.87.3#21064kodiakhq[bot] merged 2 commits intomainfrom
Conversation
| require.Equal(t, "aa:f1:cb:2e:55:8f", updatedRecord.Column(16).(*types.MACArray).ValueStr(0)) | ||
|
|
||
| updatedRecord, err = updater.DropRows([]string{"inet"}, &[]string{"139.0.16.60/10"}[0]) | ||
| updatedRecord, err = updater.DropRows([]string{"inet"}, &[]string{"139.0.0.0/10"}[0]) |
There was a problem hiding this comment.
Thinking about this more, this looks like a bug in cloudquery/plugin-sdk#2205.
We're losing the IP address data no cc @bernays?
There was a problem hiding this comment.
ParseCIDR parses s as a CIDR notation IP address and prefix length, like "192.0.2.0/24" or "2001:db8::/32", as defined in RFC 4632 and RFC 4291.
It returns the IP address and the network implied by the IP and prefix length. For example, ParseCIDR("192.0.2.1/24") returns the IP address 192.0.2.1 and the network 192.0.2.0/24.
|
OK made this ready for review despite #21064 (comment) don't think we should block the SDK update for it. In the context of |
Mhm, but doesn't this mean all |
https://github.com/cloudquery/plugin-sdk/pull/2205/files only impacts test data generation, so I think not relevant for the basic transformer (the basic transformer test rely on the test data that changed, hence the test failures). We should probably revert https://github.com/cloudquery/plugin-sdk/pull/2205/files and see why filetypes tests where failing without it (that's where we had data loss) |
🤖 I have created a release *beep* *boop* --- ## [2.6.4](plugins-transformer-basic-v2.6.3...plugins-transformer-basic-v2.6.4) (2025-07-24) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.87.3 ([#21064](#21064)) ([4a5a851](4a5a851)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.87.4 ([#21104](#21104)) ([44f77c8](44f77c8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Summary
Fixes the failing CI on the SDK update, probably due to https://github.com/cloudquery/plugin-sdk/pull/2205/files