Skip to content

chore: Remove golang-cross#21063

Merged
przste-go merged 6 commits intomainfrom
golang-cross-removal
Jul 18, 2025
Merged

chore: Remove golang-cross#21063
przste-go merged 6 commits intomainfrom
golang-cross-removal

Conversation

@przste-go
Copy link
Copy Markdown

@przste-go przste-go commented Jul 18, 2025

Summary

Golang-cross is not needed for test-plugin. It should be only used for plugins that require cgo.

@przste-go przste-go requested review from a team and maaarcelino July 18, 2025 10:44
@cq-bot cq-bot added the area/ci label Jul 18, 2025
Copy link
Copy Markdown
Member

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still need it for the CGO_ENABLED=1 plugins no? I mean DuckDB, Snowflake and SQLite

@maaarcelino
Copy link
Copy Markdown
Contributor

@przste-go "Most likely" does not fill me with confidence.. 😬 did you test this hypothesis?

@erezrokah
Copy link
Copy Markdown
Member

Looks like the test plugin is still using BoringCrypto so we'll need to change it first https://github.com/cloudquery/cloudquery/blob/85d4001576d3dc6daa2dc99e82d74cb321556676/plugins/source/test/main_fips.go

@przste-go
Copy link
Copy Markdown
Author

Looks like the test plugin is still using BoringCrypto so we'll need to change it first https://github.com/cloudquery/cloudquery/blob/85d4001576d3dc6daa2dc99e82d74cb321556676/plugins/source/test/main_fips.go

Yes, just pushed changes removing boringcrypto

Przemyslaw Stepien added 2 commits July 18, 2025 12:57
@przste-go
Copy link
Copy Markdown
Author

I think we still need it for the CGO_ENABLED=1 plugins no? I mean DuckDB, Snowflake and SQLite

Yeah you are right @erezrokah those are setting CGO: true explicitly

@przste-go
Copy link
Copy Markdown
Author

Ok, now I've left the changes only for source test plugin, all destination plugins left are using CGO

@przste-go przste-go merged commit f612c63 into main Jul 18, 2025
22 checks passed
@przste-go przste-go deleted the golang-cross-removal branch July 18, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants