fix: Version fetching code and test#2097
Merged
kodiakhq[bot] merged 5 commits intomainfrom Sep 28, 2022
Merged
Conversation
hermanschaaf
commented
Sep 27, 2022
hermanschaaf
commented
Sep 27, 2022
yevgenypats
suggested changes
Sep 28, 2022
Contributor
yevgenypats
left a comment
There was a problem hiding this comment.
Looks good. one comment: can we avoid the regex ?
yevgenypats
approved these changes
Sep 28, 2022
yevgenypats
pushed a commit
that referenced
this pull request
Sep 30, 2022
🤖 I have created a release *beep* *boop* --- ## [1.2.1-pre.1](cli-v1.2.0-pre.1...cli-v1.2.1-pre.1) (2022-09-28) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.10.2 ([#2048](#2048)) ([e407991](e407991)) * Version fetching code and test ([#2097](#2097)) ([f174f30](f174f30)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This re-instates the test for
GetLatestCLIReleaseand ensures it also works on pre-release versions.