Skip to content

chore: Update cli latest v2 version to pre-release#2094

Merged
yevgenypats merged 1 commit intomainfrom
fix-get-latest-version
Sep 27, 2022
Merged

chore: Update cli latest v2 version to pre-release#2094
yevgenypats merged 1 commit intomainfrom
fix-get-latest-version

Conversation

@hermanschaaf
Copy link
Copy Markdown
Contributor

This updates sites/versions/v2/cli.json to cli-v1.1.0-pre.1, which is a pre-release. Normally we wouldn't use pre-releases here, but having this would be better than having an empty string as we can then test the flow of end-to-end (related: #2076). It will be updated automatically as soon as we do a real v1 release.

@hermanschaaf hermanschaaf changed the title Update cli latest v2 version to pre-release chore: Update cli latest v2 version to pre-release Sep 27, 2022
@yevgenypats yevgenypats merged commit 64b60fd into main Sep 27, 2022
@yevgenypats yevgenypats deleted the fix-get-latest-version branch September 27, 2022 09:32
@erezrokah
Copy link
Copy Markdown
Member

Can you explain where we consume this version? I thought the only consumer is the GitHub action

@hermanschaaf
Copy link
Copy Markdown
Contributor Author

@erezrokah it is used by this code to detect the latest available CLI version: https://github.com/cloudquery/cloudquery/blob/main/cli/internal/plugins/versions.go#L36-L48

AFAIK currently we are not using it in the new CLI, but at some point soon we will be using it to detect whether a new version is available.

@erezrokah
Copy link
Copy Markdown
Member

@erezrokah it is used by this code to detect the latest available CLI version: https://github.com/cloudquery/cloudquery/blob/main/cli/internal/plugins/versions.go#L36-L48

That code is only used in a commented out test I think
https://github.com/cloudquery/cloudquery/search?q=GetLatestCLIRelease

@hermanschaaf
Copy link
Copy Markdown
Contributor Author

@erezrokah Yes, the test is fixed in this PR: #2097

And yeah, we're not using this function right now, but it will be used to check for new versions and then display a message on the CLI if a new version available.

@erezrokah
Copy link
Copy Markdown
Member

And yeah, we're not using this function right now, but it will be used to check for new versions and then display a message on the CLI if a new version available.

Ah makes sense, thanks for clarifying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants