fix: Re-add AWS EC2 Instance state_transition_reason_time#2087
Merged
kodiakhq[bot] merged 3 commits intocloudquery:mainfrom Sep 27, 2022
Merged
Conversation
yevgenypats
suggested changes
Sep 27, 2022
Contributor
yevgenypats
left a comment
There was a problem hiding this comment.
I wouldn't actually have this Transformation here but rather have just state_transition_reason column (I think we already have). Is this needed to any policy or we just assumed this is needed in v1 ?
Member
Author
@yevgenypats all explained in #1958 |
Contributor
|
Tricky one 😄 This particular case is pretty minor, but it could be the start of a slippery slope... Let's have a discussion about how we want to handle cases like this where we need a non-trivial transformation for use in our policy queries? |
yevgenypats
approved these changes
Sep 27, 2022
hermanschaaf
approved these changes
Sep 27, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 3, 2022
🤖 I have created a release *beep* *boop* --- ## [0.15.1-pre.0](plugins-source-aws-v0.15.0-pre.0...plugins-source-aws-v0.15.1-pre.0) (2022-10-02) ### Bug Fixes * Add ARNs to resources that were missing them ([#2099](#2099)) ([122b5c8](122b5c8)) * **deps:** Update github.com/gocarina/gocsv digest to ad3251f ([#2178](#2178)) ([94e0e83](94e0e83)) * **deps:** Update golang.org/x/sync digest to 8fcdb60 ([#2170](#2170)) ([4cd4259](4cd4259)) * **deps:** Update module github.com/aws/aws-sdk-go to v1.44.109 ([#2174](#2174)) ([e16760c](e16760c)) * **deps:** Update module github.com/aws/aws-sdk-go-v2 to v1.16.16 ([#2179](#2179)) ([de378c0](de378c0)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/waf to v1.11.17 ([#2180](#2180)) ([7f28bd4](7f28bd4)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/wafregional to v1.12.18 ([#2181](#2181)) ([f294e59](f294e59)) * **deps:** Update module github.com/aws/aws-sdk-go-v2/service/xray to v1.13.19 ([#2182](#2182)) ([cb54af0](cb54af0)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.10.2 ([#2048](#2048)) ([e407991](e407991)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.11.0 ([#2135](#2135)) ([1729467](1729467)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.11.2 ([#2162](#2162)) ([5701aa5](5701aa5)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.11.4 ([#2209](#2209)) ([1131665](1131665)) * Generate EC2 resources that were not being generated ([#2124](#2124)) ([87347f9](87347f9)) * Re-add AWS EC2 Instance state_transition_reason_time ([#2087](#2087)) ([3cf59df](3cf59df)) * Update endpoints ([#2102](#2102)) ([eb9fc3d](eb9fc3d)) * Update endpoints ([#2155](#2155)) ([6ecc34f](6ecc34f)) * Use custom resolver for Id fields ([#2117](#2117)) ([ae289a6](ae289a6)) * Use ParentResourceFieldResolver instead of ParentPathResolver ([#2126](#2126)) ([9f06971](9f06971)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #1958