feat(dest-test): Add new test destination#2057
Merged
yevgenypats merged 2 commits intomainfrom Sep 26, 2022
Merged
Conversation
hermanschaaf
approved these changes
Sep 26, 2022
Contributor
hermanschaaf
left a comment
There was a problem hiding this comment.
Approving, but left a comment regarding how we filter out builds. I would love to find a solution to that problem though
yevgenypats
pushed a commit
that referenced
this pull request
Sep 26, 2022
🤖 I have created a release *beep* *boop* --- ## [1.1.0](plugins-destination-test-v1.0.0...plugins-destination-test-v1.1.0) (2022-09-26) ### Features * **dest-test:** Add new test destination ([#2057](#2057)) ([d2e1df2](d2e1df2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
yevgenypats
added a commit
that referenced
this pull request
Sep 26, 2022
Adding a new test destination for CLI testing purposes. The new
destination plugin is basically a dev null.
Also, Im proposing/trying out a .yml per plugin ? maybe this way we can
take advantage of the built-in github
```
paths:
- "plugins/destination/test/**"
```
For destination plugins I think this is specifaclly important because
the workflows vary very much between each plugin as we need different
databases and so on.
I think for source plugin this will also start becoming a thing when we
introduce some smoke tests that will require credentials and so on.
yevgenypats
pushed a commit
that referenced
this pull request
Sep 26, 2022
🤖 I have created a release *beep* *boop* --- ## [1.1.0](plugins-destination-test-v1.0.0...plugins-destination-test-v1.1.0) (2022-09-26) ### Features * **dest-test:** Add new test destination ([#2057](#2057)) ([d2e1df2](d2e1df2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
erezrokah
reviewed
Sep 28, 2022
| on: | ||
| pull_request: | ||
| paths: | ||
| - "plugins/destination/test/**" |
Member
There was a problem hiding this comment.
Regardless where we land, the paths is missing .github/workflows/dest_test.yml, otherwise changes to the workflow file won't trigger it (for example in a PR)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a new test destination for CLI testing purposes. The new destination plugin is basically a dev null.
Also, Im proposing/trying out a .yml per plugin ? maybe this way we can take advantage of the built-in github
For destination plugins I think this is specifaclly important because the workflows vary very much between each plugin as we need different databases and so on.
I think for source plugin this will also start becoming a thing when we introduce some smoke tests that will require credentials and so on.