fix: Replace internal columns if exist on Cloud syncs#20456
Merged
kodiakhq[bot] merged 4 commits intomainfrom Mar 31, 2025
Merged
fix: Replace internal columns if exist on Cloud syncs#20456kodiakhq[bot] merged 4 commits intomainfrom
kodiakhq[bot] merged 4 commits intomainfrom
Conversation
murarustefaan
approved these changes
Mar 31, 2025
kodiakhq bot
pushed a commit
that referenced
this pull request
Mar 31, 2025
🤖 I have created a release *beep* *boop* --- ## [6.17.2](cli-v6.17.1...cli-v6.17.2) (2025-03-31) ### Bug Fixes * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.13.8 ([#20457](#20457)) ([b94b89c](b94b89c)) * **deps:** Update module golang.org/x/net to v0.38.0 ([#20453](#20453)) ([b5a4289](b5a4289)) * Replace internal columns if exist on Cloud syncs ([#20456](#20456)) ([afad73e](afad73e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Goes with cloudquery/plugin-sdk#2105
For Cloud syncs we should replace the internal columns if exist so we can trace back the synced data to the correct source name, sync time and sync group id (otherwise we'd get the ones of the original sync, e.g.
AWS->S3)