feat!: Migrate k8s plugin to v2#2035
Merged
yevgenypats merged 2 commits intocloudquery:mainfrom Sep 29, 2022
shimonp21:k8s_cqv2_
Merged
feat!: Migrate k8s plugin to v2#2035yevgenypats merged 2 commits intocloudquery:mainfrom shimonp21:k8s_cqv2_
yevgenypats merged 2 commits intocloudquery:mainfrom
shimonp21:k8s_cqv2_
Conversation
yevgenypats
suggested changes
Sep 23, 2022
Contributor
yevgenypats
left a comment
There was a problem hiding this comment.
Added comments.
For initial PR to go through we don't need policies but we do need documentation (gen command is deprecated) - see gcp,azure,aws as example for plugin documentation and guidelines - https://cloudqueryio.slack.com/archives/C021N25N0TC/p1663939265680039
plugins/source/k8s/resources/services/apps/replica_sets_fetch.go
Outdated
Show resolved
Hide resolved
yevgenypats
reviewed
Sep 23, 2022
shimonp21
commented
Sep 27, 2022
hermanschaaf
approved these changes
Sep 27, 2022
Contributor
hermanschaaf
left a comment
There was a problem hiding this comment.
Looks great 👍 I only really have a comment about using the new string case conversion from plugin-sdk, otherwise all looks good to me. (I won't claim I read every last resource in detail, but I did skim a couple :) )
Contributor
|
Oh also some linting errors that will need to be fixed before we can merge |
yevgenypats
approved these changes
Sep 28, 2022
This was referenced Sep 29, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 2, 2022
🤖 I have created a release *beep* *boop* --- ## [1.0.0-pre.0](plugins-source-k8s-v0.6.4-pre.0...plugins-source-k8s-v1.0.0-pre.0) (2022-10-02) ### ⚠ BREAKING CHANGES * Migrate k8s plugin to v2 (#2035) ### Features * Migrate k8s plugin to v2 ([#2035](#2035)) ([955b742](955b742)) ### Bug Fixes * **deps:** Update kubernetes packages to v0.25.2 ([#2176](#2176)) ([03e27da](03e27da)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.11.0 ([#2135](#2135)) ([1729467](1729467)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.11.2 ([#2162](#2162)) ([5701aa5](5701aa5)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.11.4 ([#2216](#2216)) ([093fffb](093fffb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
daniel-garcia
pushed a commit
to infobloxopen/ibcq-source-k8s
that referenced
this pull request
Feb 24, 2026
🤖 I have created a release *beep* *boop* --- ## [1.0.0-pre.0](cloudquery/cloudquery@plugins-source-k8s-v0.6.4-pre.0...plugins-source-k8s-v1.0.0-pre.0) (2022-10-02) ### ⚠ BREAKING CHANGES * Migrate k8s plugin to v2 (#2035) ### Features * Migrate k8s plugin to v2 ([#2035](cloudquery/cloudquery#2035)) ([19710bb](cloudquery/cloudquery@19710bb)) ### Bug Fixes * **deps:** Update kubernetes packages to v0.25.2 ([#2176](cloudquery/cloudquery#2176)) ([bead6ee](cloudquery/cloudquery@bead6ee)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.11.0 ([#2135](cloudquery/cloudquery#2135)) ([1050154](cloudquery/cloudquery@1050154)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.11.2 ([#2162](cloudquery/cloudquery#2162)) ([ab646bd](cloudquery/cloudquery@ab646bd)) * **deps:** Update module github.com/cloudquery/plugin-sdk to v0.11.4 ([#2216](cloudquery/cloudquery#2216)) ([46f53f7](cloudquery/cloudquery@46f53f7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What is left to do for the plugin:
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)