feat: Support all batch writers in test destination plugin.#19964
Merged
kodiakhq[bot] merged 5 commits intomainfrom Dec 13, 2024
Merged
feat: Support all batch writers in test destination plugin.#19964kodiakhq[bot] merged 5 commits intomainfrom
kodiakhq[bot] merged 5 commits intomainfrom
Conversation
erezrokah
reviewed
Dec 13, 2024
plugins/destination/test/go.mod
Outdated
| github.com/apache/arrow/go/v17 v17.0.0 | ||
| github.com/cloudquery/codegen v0.3.21 | ||
| github.com/cloudquery/plugin-sdk/v4 v4.71.1 | ||
| github.com/cloudquery/plugin-sdk/v4 v4.72.0 |
Member
There was a problem hiding this comment.
I'll hold off updating to this SDK version otherwise you'd have two arrow versions in the plugin, v17 and v18.
The update is done via #19963
Contributor
Author
There was a problem hiding this comment.
Downgraded. The reason I initially upgraded was to see if the streambatchwriter issue was already fixed.
erezrokah
approved these changes
Dec 13, 2024
Member
erezrokah
left a comment
There was a problem hiding this comment.
Looks good so can be merged without the SDK update
Contributor
Author
|
Ran the tests after downgrading arrow. Tests still behave the same. |
marianogappa
pushed a commit
that referenced
this pull request
Dec 16, 2024
🤖 I have created a release *beep* *boop* --- ## [2.8.0](plugins-destination-test-v2.7.1...plugins-destination-test-v2.8.0) (2024-12-16) ### Features * Support all batch writers in test destination plugin. ([#19964](#19964)) ([f159291](f159291)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.71.1 ([#19934](#19934)) ([0143675](0143675)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.72.0 ([#19963](#19963)) ([80b3c97](80b3c97)) * Fix hang in test destination plugin. ([#19970](#19970)) ([864dd65](864dd65)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds spec options for all 3 batch writers on the test destination plugin.
My tests show that all 3 can be used. However, the streamBatchWriter CLI tests are getting stuck. This shouldn't block this PR, on the contrary, it might be good to add tests to the CLI using the
streamBatchWriterand figure out why it's getting stuck.Testing with this spec
Test pass when omitting the streamBatchWriter
