Merged
Conversation
14f03ef to
96384c4
Compare
96384c4 to
a1e30ed
Compare
erezrokah
commented
Nov 22, 2024
| outputs: | ||
| plugin_name: ${{ steps.split.outputs.plugin_name }} | ||
| plugin_kind: ${{ steps.split.outputs.plugin_kind }} | ||
| plugin_version: ${{ steps.split.outputs.plugin_version }}-fips |
Member
Author
There was a problem hiding this comment.
Notice we append -fips to the version here
murarustefaan
approved these changes
Nov 22, 2024
Member
|
I'd say let's wait and see whether @bernays is also ok with this approach. |
marianogappa
approved these changes
Nov 22, 2024
bbernays
approved these changes
Nov 25, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 25, 2024
🤖 I have created a release *beep* *boop* --- ## [4.6.0](plugins-source-test-v4.5.5...plugins-source-test-v4.6.0) (2024-11-25) ### Features * Add FIPS version ([#19676](#19676)) ([bcdf696](bcdf696)) * Add license information ([#19642](#19642)) ([a81edd6](a81edd6)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.69.0 ([#19677](#19677)) ([84cd7bd](84cd7bd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Merged
erezrokah
added a commit
that referenced
this pull request
Nov 25, 2024
<!-- 🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉 --> #### Summary Forgot the actual publishing part in #19676, everything else worked https://github.com/cloudquery/cloudquery/actions/runs/12014258222/job/33489640405 Did an invisible change to the readme to trigger a new release <!-- Use the following steps to ensure your PR is ready to be reviewed - [ ] Read the [contribution guidelines](https://github.com/cloudquery/cloudquery/blob/main/CONTRIBUTING.md) 🧑🎓 - [ ] Run `make lint` to ensure the proposed changes follow the coding style 🚨 (install golangci-lint [here](https://golangci-lint.run/usage/install/#local-installation)) - [ ] Run `make test` to ensure the proposed changes pass the tests 🧪 - [ ] If changing a source plugin run `make gen` to ensure docs are up to date 📝 - [ ] Ensure the status checks below are successful ✅ --->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is intended to add a FIPS version of the test source plugin, it works only for linux arm64 and amd64, since that's what
boringcryptosupports.Needs cloudquery/plugin-sdk#1974 for validation