feat: Implement custom ORDER BY clause support.#19674
Merged
kodiakhq[bot] merged 2 commits intomainfrom Nov 21, 2024
Merged
Conversation
Contributor
|
🚀 ClickHouse Cloud UI deployed to Vercel: |
erezrokah
approved these changes
Nov 21, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 29, 2024
🤖 I have created a release *beep* *boop* --- ## [6.0.0](plugins-destination-clickhouse-v5.2.0...plugins-destination-clickhouse-v6.0.0) (2024-11-29) ### ⚠ BREAKING CHANGES * Fix the order by bug that causes compound types to always be included in the sort key * Detect changes to order and partition by and fail migration (or recreate tables in `force_migrate` mode) ### Features * Detect changes to order and partition by and fail migration (or recreate tables in `force_migrate` mode) ([8c355f7](8c355f7)) * Implement custom ORDER BY clause support. ([#19674](#19674)) ([14f8a41](14f8a41)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.69.0 ([#19677](#19677)) ([84cd7bd](84cd7bd)) * Fix the order by bug that causes compound types to always be included in the sort key ([8c355f7](8c355f7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements support for setting custom ORDER BY clauses on any table or group of tables in the ClickHouse destination.
Because tables are defined on the source side and every destination can have different optimal indexing/sorting circumstances, it is not practical to define destination-specific sorting strategies at the source. Therefore, this enables setting it at the destination.