Merged
Conversation
erezrokah
commented
Oct 14, 2024
| steps: | ||
| - name: Git checkout | ||
| uses: actions/checkout@v4 | ||
| - run: | |
Member
Author
There was a problem hiding this comment.
erezrokah
commented
Oct 14, 2024
| echo "$venv/bin" >> $GITHUB_PATH | ||
| - name: Vale | ||
| uses: errata-ai/vale-action@38bf078c328061f59879b347ca344a718a736018 | ||
| uses: errata-ai/vale-action@3a4769d4af5f9498e586fb41abc72bbca594b400 |
Member
Author
There was a problem hiding this comment.
Updated to latest version while we're at it
marianogappa
approved these changes
Oct 14, 2024
5 tasks
erezrokah
added a commit
to cloudquery/plugin-sdk
that referenced
this pull request
Oct 15, 2024
#### Summary Same as cloudquery/cloudquery#19372 --- Use the following steps to ensure your PR is ready to be reviewed - [ ] Read the [contribution guidelines](../blob/main/CONTRIBUTING.md) 🧑🎓 - [ ] Run `go fmt` to format your code 🖊 - [ ] Lint your changes via `golangci-lint run` 🚨 (install golangci-lint [here](https://golangci-lint.run/usage/install/#local-installation)) - [ ] Update or add tests 🧪 - [ ] Ensure the status checks below are successful ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes this failure in our CI that started showing up https://github.com/cloudquery/cloudquery/actions/runs/11325041150/job/31491094977?pr=19372#step:3:16