chore(main): Revert Documentation Quickstart Guides to AWS from XKCD #2560#19355
Merged
kodiakhq[bot] merged 6 commits intocloudquery:mainfrom Oct 14, 2024
Merged
Conversation
erezrokah
requested changes
Oct 14, 2024
Member
erezrokah
left a comment
There was a problem hiding this comment.
Thanks @JoeKarlsson looks great. Added a couple of comments
Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
erezrokah
reviewed
Oct 14, 2024
Member
erezrokah
left a comment
There was a problem hiding this comment.
Not sure if we want to use a mock account ID or our own in the results
Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com>
erezrokah
approved these changes
Oct 14, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 14, 2024
#### Summary Follow up to #19355
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With our new product focus, we are realigning the Quickstart guides to emphasize our core cloud competencies. To that end, we need to revert the Quickstart guides back to using AWS, instead of the current XKCD integration. This change is critical for accelerating users’ ability to engage with practical cloud use cases. The faster we can enable them to leverage AWS, the better.
Ticket: https://github.com/cloudquery/cloudquery-issues/issues/2560