fix: Auto detect SVG content-type#19342
Merged
kodiakhq[bot] merged 6 commits intomainfrom Oct 10, 2024
Merged
Conversation
erezrokah
reviewed
Oct 10, 2024
| }{ | ||
| { | ||
| filename: "octetstream.svg", | ||
| data: []byte(`<svg xmlns="http://www.w3.org/2000/svg" width="2500" height="330" viewBox="0 0 719.713 94.943"><g fill-rule="evenodd" clip-rule="evenodd"><path d="M17.32,16.76l-.53.53-1.09-1.1a4.33,4.33,0,0,0,.53-.52Z" style="fill:#4285f4"/></g></svg>`), |
Member
There was a problem hiding this comment.
Can we embed these files instead to make it easier to read the tests?
erezrokah
reviewed
Oct 10, 2024
cli/internal/publish/pluginui.go
Outdated
| contentType := http.DetectContentType(filebytes) | ||
| if contentType == "application/octet-stream" { | ||
| switch { | ||
| case contentType == "application/octet-stream": |
Member
There was a problem hiding this comment.
We can use the mime package similar to golang/go#15888 (comment) WDYT?
Contributor
|
Linting error in the latest commit: |
erezrokah
approved these changes
Oct 10, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 10, 2024
🤖 I have created a release *beep* *boop* --- ## [6.8.3](cli-v6.8.2...cli-v6.8.3) (2024-10-10) ### Bug Fixes * Auto detect SVG content-type ([#19342](#19342)) ([f355be8](f355be8)) * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.22.4 ([#19274](#19274)) ([c6eda0c](c6eda0c)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.64.0 ([#19287](#19287)) ([49941ee](49941ee)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.65.0 ([#19322](#19322)) ([87a68ea](87a68ea)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.66.0 ([#19332](#19332)) ([137a232](137a232)) * **deps:** Update module google.golang.org/grpc to v1.67.0 ([#19255](#19255)) ([a154662](a154662)) * **deps:** Update module google.golang.org/grpc to v1.67.1 ([#19327](#19327)) ([5299c4b](5299c4b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.