fix: Close Transformers pipeline on both source and destination closes#19105
Merged
kodiakhq[bot] merged 4 commits intomainfrom Sep 6, 2024
Merged
fix: Close Transformers pipeline on both source and destination closes#19105kodiakhq[bot] merged 4 commits intomainfrom
kodiakhq[bot] merged 4 commits intomainfrom
Conversation
marianogappa
reviewed
Sep 6, 2024
marianogappa
approved these changes
Sep 6, 2024
erezrokah
reviewed
Sep 6, 2024
|
|
||
| // Close the first transformer. The rest will follow gracefully, otherwise records will be lost. | ||
| return lp.clientWrappers[0].client.CloseSend() | ||
| lp.clientWrappers[0].client.CloseSend() |
Member
There was a problem hiding this comment.
Suggested change
| lp.clientWrappers[0].client.CloseSend() | |
| _ = lp.clientWrappers[0].client.CloseSend() |
You might need this to tell the linter you're ignoring the error from CloseSend()
Member
There was a problem hiding this comment.
But you can ignore this if the linter passes
erezrokah
approved these changes
Sep 6, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 6, 2024
🤖 I have created a release *beep* *boop* --- ## [6.6.2](cli-v6.6.1...cli-v6.6.2) (2024-09-06) ### Bug Fixes * Close Transformers pipeline on both source and destination closes ([#19105](#19105)) ([25682d6](25682d6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.