fix: Better connection tester error codes #18920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
approved these changes
Aug 13, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 13, 2024
🤖 I have created a release *beep* *boop* --- ## [8.5.0](plugins-destination-postgresql-v8.4.0...plugins-destination-postgresql-v8.5.0) (2024-08-13) ### Features * Configure initial type of PostgreSQL cloud UI depending if destination is managed ([#18868](#18868)) ([81c36df](81c36df)) ### Bug Fixes * Better connection tester error codes ([#18920](#18920)) ([b7e1ad4](b7e1ad4)) * **deps:** Update dependency @cloudquery/cloud-ui to v0.1.13 ([#18874](#18874)) ([73f5ff0](73f5ff0)) * **deps:** Update dependency @cloudquery/plugin-config-ui-connector to v0.2.12 ([#18869](#18869)) ([47734e3](47734e3)) * **deps:** Update dependency @cloudquery/plugin-config-ui-connector to v0.2.13 ([#18911](#18911)) ([85425cb](85425cb)) * **deps:** Update dependency @cloudquery/plugin-config-ui-lib to ^0.0.54 ([#18870](#18870)) ([8c5a436](8c5a436)) * **deps:** Update dependency @cloudquery/plugin-config-ui-lib to ^0.0.55 ([#18877](#18877)) ([07e176b](07e176b)) * **deps:** Update dependency @cloudquery/plugin-config-ui-lib to ^0.0.56 ([#18904](#18904)) ([62fbd9a](62fbd9a)) * **deps:** Update dependency @cloudquery/plugin-config-ui-lib to ^0.0.57 ([#18912](#18912)) ([f4ebbfb](f4ebbfb)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.59.0 ([#18881](#18881)) ([8f7667f](8f7667f)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.60.0 ([#18922](#18922)) ([7626636](7626636)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're relying on error codes more, we need to provide more than just
UNKNOWN(which is the default if a non-TestConnErrorerror is returned)Should help with https://github.com/cloudquery/cloudquery-issues/issues/2129 (internal issue)