feat: XKCD source plugin UI v2 #18837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cduflo
approved these changes
Aug 2, 2024
| error={!!fieldState.error} | ||
| fullWidth={true} | ||
| helperText={fieldState.error?.message} | ||
| helperText={ |
Contributor
There was a problem hiding this comment.
@rhino1998 we have a new pattern (very recent, you didn't miss it) to use the getFieldHelperText util from the plugin-config-ui-lib that will keep showing the helper text in addition to the error text
Contributor
There was a problem hiding this comment.
so minor, but may be worth converting to webp
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 5, 2024
🤖 I have created a release *beep* *boop* --- ## [1.3.0](plugins-source-xkcd-v1.2.0...plugins-source-xkcd-v1.3.0) (2024-08-04) ### Features * XKCD source plugin UI v2 ([#18837](#18837)) ([5a20677](5a20677)) ### Bug Fixes * **deps:** Update dependency @cloudquery/cloud-ui to v0.1.12 ([#18836](#18836)) ([b24afab](b24afab)) * **deps:** Update dependency @cloudquery/plugin-config-ui-connector to v0.2.10 ([#18850](#18850)) ([ec926b5](ec926b5)) * **deps:** Update dependency @cloudquery/plugin-config-ui-lib to ^0.0.42 ([#18834](#18834)) ([827d13b](827d13b)) * **deps:** Update dependency @cloudquery/plugin-config-ui-lib to ^0.0.44 ([#18838](#18838)) ([745aeca](745aeca)) * **deps:** Update dependency @cloudquery/plugin-config-ui-lib to ^0.0.45 ([#18841](#18841)) ([4476f38](4476f38)) * **deps:** Update dependency @cloudquery/plugin-config-ui-lib to ^0.0.46 ([#18844](#18844)) ([60f5924](60f5924)) * **deps:** Update dependency @cloudquery/plugin-config-ui-lib to ^0.0.47 ([#18849](#18849)) ([029638e](029638e)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.57.1 ([#18830](#18830)) ([605c202](605c202)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.58.0 ([#18839](#18839)) ([6b57bca](6b57bca)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Tweak the XKCD source plugin UI