feat: Support table name changes on basic transformer. #18833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
reviewed
Aug 2, 2024
Member
erezrokah
left a comment
There was a problem hiding this comment.
Looks good, added a few comments
erezrokah
approved these changes
Aug 2, 2024
erezrokah
approved these changes
Aug 2, 2024
This was referenced Aug 2, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 5, 2024
🤖 I have created a release *beep* *boop* --- ## [6.3.0](cli-v6.2.0...cli-v6.3.0) (2024-08-05) ### Features * Implement transformations support. ([#18669](#18669)) ([2af93ed](2af93ed)) * Support table name changes on basic transformer. ([#18833](#18833)) ([67d3701](67d3701)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.12.6 ([#18828](#18828)) ([3a48c89](3a48c89)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.57.1 ([#18830](#18830)) ([605c202](605c202)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.58.0 ([#18839](#18839)) ([6b57bca](6b57bca)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.58.1 ([#18852](#18852)) ([4320340](4320340)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 5, 2024
🤖 I have created a release *beep* *boop* --- ## 1.0.0 (2024-08-05) ### Features * Implement basic transformer (add/remove/obfuscate columns) ([#18704](#18704)) ([704102f](704102f)) * Support table name changes on basic transformer. ([#18833](#18833)) ([67d3701](67d3701)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.12.0 ([#18448](#18448)) ([a5850e1](a5850e1)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v4 ([#18822](#18822)) ([bfd8765](bfd8765)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v2 to v4 ([#18842](#18842)) ([39beee4](39beee4)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.57.0 ([#18821](#18821)) ([ef364a2](ef364a2)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.57.1 ([#18830](#18830)) ([605c202](605c202)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.58.0 ([#18839](#18839)) ([6b57bca](6b57bca)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.58.1 ([#18852](#18852)) ([4320340](4320340)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new transformation kind to the basic transformer that enables renaming tables.
Used like:
Unfortunately,
sync_v3has to be updated to support this transformation, because the sync process deletes stale rows, and it supplies the old table names, and there's no way to ask the transformer how did you change the names.Therefore, I added a very small
tableNameChangerthat learns table name changes by sniffing schema bytes onTransformSchemacalls (viaMigrateTableMessage), and updates the names where it needs to.