feat: Add MSSQL connection test #18568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Can you also test out the 'unreachable' scenario? It's probably enough to try running the test connection with mssql container stopped |
Contributor
Author
I tested all the error states but didn't include the output in the PR description to keep it short. Here's what it looks like if you're curious: > cloudquery test-connection mssql.yaml
Loading spec(s) from mssql.yaml
Test Connection Results
destination mssql (grpc@localhost:7777) Failure: UNREACHABLE unable to open tcp connection with host 'localhost:1433': dial tcp [::1]:1433: connect: connection refused
Error: at least one test connection failed |
blesniewski
approved these changes
Jul 15, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
🤖 I have created a release *beep* *boop* --- ## [4.7.0](plugins-destination-mssql-v4.6.8...plugins-destination-mssql-v4.7.0) (2024-07-16) ### Features * Add MSSQL connection test ([#18568](#18568)) ([2aa965f](2aa965f)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.49.3 ([#18513](#18513)) ([d12da90](d12da90)) * Fix user id format in example configuration comment ([#18561](#18561)) ([71eb413](71eb413)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements MSSQL connection test.