fix: Fix pagination logic for responses on Typeform plugin. #18479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 9, 2024
🤖 I have created a release *beep* *boop* --- ## [1.5.0](plugins-source-typeform-v1.4.3...plugins-source-typeform-v1.5.0) (2024-07-09) ### Features * Implement support for Incremental Table on Typeform's FormResponses table ([#18492](#18492)) ([5127370](5127370)) ### Bug Fixes * **deps:** Update dependency cloudquery-plugin-sdk to v0.1.28 ([#18509](#18509)) ([e1cf3ad](e1cf3ad)) * **deps:** Update module github.com/cloudquery/cloudquery-api-go to v1.12.0 ([#18448](#18448)) ([a5850e1](a5850e1)) * Fix pagination logic for responses on Typeform plugin. ([#18479](#18479)) ([d0923b0](d0923b0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/cloudquery/cloudquery-issues/issues/1976
Within the Typeform plugin, the client's logic for pagination of
forms_responsesis a recursive call that omits theform_id. It's likely that we never encountered this problem because the page size is 1000.