fix!: Support Apache Arrow types with non-default options #18198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermanschaaf
approved these changes
Jun 11, 2024
erezrokah
reviewed
Jun 11, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 11, 2024
🤖 I have created a release *beep* *boop* --- ## [4.0.0](plugins-destination-bigquery-v3.6.1...plugins-destination-bigquery-v4.0.0) (2024-06-11) ### ⚠ BREAKING CHANGES * Apache Arrow `timestamp` now always maps to BigQuery `timestamp` type ([#18198](#18198)). Previously, `timestamp` with `nanoseconds` precision was mapped to a `record` type. ### Features * Remove logging of error events to Sentry in plugins ([#18165](#18165)) ([fc4ff27](fc4ff27)) ### Bug Fixes * **deps:** Update module google.golang.org/api to v0.183.0 ([#18195](#18195)) ([c560cfa](c560cfa)) * Support Apache Arrow types with non-default options ([#18198](#18198)). Previously some Apache Arrow types (namely, `timestamp` with non-default time zone) would result in plugin failure. ([4b775f9](4b775f9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
fix: Support Apache Arrow types with non-default options (#18198). Previously some Apache Arrow types (namely,
timestampwith non-default time zone) would result in plugin failure.BREAKING-CHANGE: Apache Arrow
timestampnow always maps to BigQuerytimestamptype (#18198). Previously,timestampwithnanosecondsprecision was mapped to arecordtype.END_COMMIT_OVERRIDE
Instead of #18126
Fixes https://github.com/cloudquery/cloudquery-issues/issues/1786 (internal issue)