fix: Check if CQ_ANALYTICS_HOST exists to determine if a custom host is set#18124
Merged
kodiakhq[bot] merged 2 commits intocloudquery:mainfrom Jun 4, 2024
Merged
fix: Check if CQ_ANALYTICS_HOST exists to determine if a custom host is set#18124kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
CQ_ANALYTICS_HOST exists to determine if a custom host is set#18124kodiakhq[bot] merged 2 commits intocloudquery:mainfrom
Conversation
marianogappa
approved these changes
Jun 4, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Jun 6, 2024
🤖 I have created a release *beep* *boop* --- ## [5.20.5](cli-v5.20.4...cli-v5.20.5) (2024-06-06) ### Bug Fixes * Check if `CQ_ANALYTICS_HOST` exists to determine if a custom host is set ([#18124](#18124)) ([c6f5bbf](c6f5bbf)) * Progressbar related error when `log-console` option is used ([#18161](#18161)) ([bbac469](bbac469)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Noticed this while working on adding Rudderstack to the CLI.
os.Getenv("CQ_ANALYTICS_HOST")returns an empty string if the env variable is not set, so not setting it meanscustomAnalyticsHostis always true.