feat: Add explicit Test Connection support for DuckDB #17999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disq
commented
May 17, 2024
|
|
||
| connector, err := duckdb.NewConnector(amendConnectionString(s.ConnectionString), nil) | ||
| if err != nil { | ||
| return err |
Member
Author
There was a problem hiding this comment.
go-duckdb errors seem to be clear and not so deeply wrapped, that's why I omitted the processError(err) step here.
bbernays
approved these changes
May 20, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
May 21, 2024
🤖 I have created a release *beep* *boop* --- ## [5.8.0](plugins-destination-duckdb-v5.7.0...plugins-destination-duckdb-v5.8.0) (2024-05-21) ### Features * Add explicit Test Connection support for DuckDB ([#17999](#17999)) ([2a1e46d](2a1e46d)) ### Bug Fixes * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.42.1 ([#17965](#17965)) ([d652b81](d652b81)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.42.2 ([#18000](#18000)) ([5fc0f46](5fc0f46)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.43.0 ([#18014](#18014)) ([20592c8](20592c8)) * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.43.1 ([#18026](#18026)) ([364307c](364307c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the explicit test connection support effort.