Skip to content

feat!: Migrate DigitalOcean plugin to v2#1794

Merged
erezrokah merged 37 commits intocloudquery:mainfrom
amanenk:feat/do_sdk_v2
Sep 21, 2022
Merged

feat!: Migrate DigitalOcean plugin to v2#1794
erezrokah merged 37 commits intocloudquery:mainfrom
amanenk:feat/do_sdk_v2

Conversation

@amanenk
Copy link
Copy Markdown
Contributor

@amanenk amanenk commented Sep 13, 2022

Summary


Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Test locally on your own infrastructure
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests 🧪
  • Ensure the status checks below are successful ✅

@amanenk amanenk changed the title feat: digitalocean migration to a new SDK feat: Digitalocean migration to a new SDK Sep 13, 2022
@amanenk amanenk marked this pull request as ready for review September 13, 2022 08:28
@amanenk amanenk requested review from a team and SCKelemen and removed request for a team September 13, 2022 08:28
disq
disq previously requested changes Sep 13, 2022
Copy link
Copy Markdown
Member

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks 🚀 @amanenk.

Left some comments and I'd also keep docs/tables otherwise it will create broken links in our site

@erezrokah
Copy link
Copy Markdown
Member

@amanenk approved, but we still need the docs/tables back

Copy link
Copy Markdown
Contributor

@hermanschaaf hermanschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Hopefully the last round of changes I'm requesting 😅 Let me know if you'd prefer to do it in a follow-up PR instead

@github-actions github-actions bot removed the cli label Sep 20, 2022
@github-actions github-actions bot removed the gcp label Sep 20, 2022
@hermanschaaf hermanschaaf added the automerge Automatically merge once required checks pass label Sep 21, 2022
@erezrokah erezrokah merged commit e556185 into cloudquery:main Sep 21, 2022
kodiakhq bot pushed a commit that referenced this pull request Sep 21, 2022
🤖 I have created a release *beep* *boop*
---


## [0.7.0-pre.0](plugins/source/digitalocean-v0.6.5-pre.0...plugins/source/digitalocean/v0.7.0-pre.0) (2022-09-21)


### ⚠ BREAKING CHANGES

* Migrate DigitalOcean plugin to v2 (#1794)

### Features

* Add Sentry DSN ([#1913](#1913)) ([5cc036e](5cc036e))
* Added throttling for digitalocean API calls ([#1546](#1546)) ([bb40b59](bb40b59))
* Migrate DigitalOcean plugin to v2 ([#1794](#1794)) ([e556185](e556185))


### Bug Fixes

* **deps:** Update Terraform tls to v4.0.2 ([#1653](#1653)) ([8f3bbeb](8f3bbeb))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants