Skip to content

chore: Remove Notion and Firestore #17903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kodiakhq merged 1 commit into from
May 14, 2024
Merged

chore: Remove Notion and Firestore #17903

kodiakhq merged 1 commit into from
May 14, 2024

Conversation

@erezrokah
Copy link
Member

@erezrokah erezrokah commented May 7, 2024

Summary

Similar to #17779, see https://www.cloudquery.io/blog/cloudquery-official-free-plugins-moving-to-paid

We reached out to the original authors and didn't get a response, so removing these

@erezrokah erezrokah requested review from a team and maaarcelino and removed request for a team May 7, 2024 16:30
@erezrokah erezrokah added the automerge Automatically merge once required checks pass label May 7, 2024
@cq-bot
Copy link
Contributor

cq-bot commented May 7, 2024

This PR has the following changes to source plugin(s) tables:

  • ⚠️ BREAKING CHANGE: Table notion_databases_table was removed
  • ⚠️ BREAKING CHANGE: Table notion_pages_table was removed
  • ⚠️ BREAKING CHANGE: Table notion_users_table was removed

@erezrokah erezrokah force-pushed the chore/remove_firestore_notion branch from 0a56e3f to b756a10 Compare May 14, 2024 10:38
@kodiakhq kodiakhq bot merged commit f21f62b into cloudquery:main May 14, 2024
@erezrokah erezrokah mentioned this pull request May 14, 2024
Merged
kodiakhq bot pushed a commit that referenced this pull request May 14, 2024
@erezrokah
chore: Remove old integration pages (#17958)
97e2c67 
#### Summary

Not sure why the Website build didn't fail in #17903, but it fails on `main`:

```
Error: No _configuration.md file found for source: firestore
--
15:37:38.719 | at <anonymous> (/vercel/path0/website/scripts/prebuild.tsx:166:17)
```

We shouldn't generate integration pages at all and redirect per #16681
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@maaarcelino maaarcelino maaarcelino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/ci area/plugin/source/firestore area/plugin/source/notion automerge Automatically merge once required checks pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@erezrokah @cq-bot @maaarcelino